feat(s2n-quic-crypto): use aws-lc-rs on linux/aarch64 #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We're fixing the build issues in #1717. After that is merged we can rebase this on main. |
justsmth
changed the title
justsmth
changed the title
justsmth
force-pushed
the
migration-aws-lc-rs
branch
from
409ab17
to
007753e
Compare
camshaft
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Relates to #1683
Description of changes:
This change migrates the cryptographic library used on unix platforms from ring to aws-lc-rs.
Call-outs:
aws-lc-rs does not yet support Windows platforms, but support for Windows is planned. For non-unix platforms, ring will continue to be used.
Testing:
Performed the release build and tests. Ran rustfmt and clippy.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.